Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/ provider error on flyover instance #915

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

ronaldsg20
Copy link
Member

No description provided.

Copy link

github-actions bot commented Nov 18, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

		I've defined the provider parameter on the flyover instance depending
		on the option, for pegin it will use an annonymus wallet and for pegout
		the rlogin provider connected.
@ronaldsg20 ronaldsg20 marked this pull request as ready for review November 21, 2024 21:01
@@ -10,6 +10,7 @@ import { EnvironmentAccessorService } from '@/common/services/enviroment-accesso

export const actions: ActionTree<FlyoverPeginState, RootState> = {
[constants.FLYOVER_PEGIN_INIT]: ({ state, dispatch }) => new Promise((resolve, reject) => {
console.log('FlyoverPegin inti flyover');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@leoiovlabs leoiovlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexjavabraz alexjavabraz merged commit 5487678 into feature/2.3 Nov 28, 2024
3 of 4 checks passed
@alexjavabraz alexjavabraz deleted the bugfix/user-met-trez branch November 28, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants